Fix Windows table output formatting (#4989) #6381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2 #6381 +/- ##
==========================================
- Coverage 94.20% 94.03% -0.18%
==========================================
Files 273 273
Lines 21788 21541 -247
==========================================
- Hits 20526 20256 -270
- Misses 1262 1285 +23
Continue to review full report at Codecov.
|
|
Hi @justindho, thanks for this pull request and for your patience. After review with the team, we've made the decision to close this pull request as not planned, but are leaving the issue open for tracking purposes. For the time being, please continue using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #4989
Description of changes:
Fixes issue of showing ANSI escape character sequences for colors in the table output on Windows. Changes have been tested on Windows, MacOS, and Linux.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.